davejansen/lidgren-network-gen3
1
0
Fork 0
mirror of https://github.com/lidgren/lidgren-network-gen3.git synced 2026-05-17 15:46:33 +09:00
Code Issues Releases Activity

Fix for possible race condition resulting in duplicate message recycling

Browse Source 
Fix for DoS vulnerability with incoming acks
This commit is contained in:
lidgren
2014-08-10 18:46:26 +00:00
parent 54ff6f1c37
commit 092bd4d536
2 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
Lidgren.Network/NetConnection.cs
View File

@@ -234,8 +234,11 @@ namespace Lidgren.Network
{ {
//m_peer.LogVerbose("Received ack for " + acktp + "#" + seqNr); //m_peer.LogVerbose("Received ack for " + acktp + "#" + seqNr);
NetSenderChannelBase chan = m_sendChannels[(int)incAck.Item1 - 1]; NetSenderChannelBase chan = m_sendChannels[(int)incAck.Item1 - 1];
// If we haven't sent a message on this channel there is no reason to ack it
if (chan == null) if (chan == null)
chan = CreateSenderChannel(incAck.Item1); continue;
chan.ReceiveAcknowledge(now, incAck.Item2); chan.ReceiveAcknowledge(now, incAck.Item2);
} }
} }

3
Lidgren.Network/NetReliableSenderChannel.cs
View File

@@ -138,8 +138,7 @@ namespace Lidgren.Network
if (storedMessage != null) if (storedMessage != null)
{ {
#endif #endif
Interlocked.Decrement(ref storedMessage.m_recyclingCount); if (Interlocked.Decrement(ref storedMessage.m_recyclingCount) <= 0)
if (storedMessage.m_recyclingCount <= 0)
m_connection.m_peer.Recycle(storedMessage); m_connection.m_peer.Recycle(storedMessage);
#if !DEBUG #if !DEBUG