From 715746eed32302a64e507393430dd2608a0fa41a Mon Sep 17 00:00:00 2001 From: lidgren Date: Tue, 12 Aug 2014 20:44:39 +0000 Subject: [PATCH] Removed unnecessary allocation --- Lidgren.Network/NetPeer.Fragmentation.cs | 2 +- Lidgren.Network/NetPeer.MessagePools.cs | 10 ++++------ 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/Lidgren.Network/NetPeer.Fragmentation.cs b/Lidgren.Network/NetPeer.Fragmentation.cs index 8c1ea93..afb092d 100644 --- a/Lidgren.Network/NetPeer.Fragmentation.cs +++ b/Lidgren.Network/NetPeer.Fragmentation.cs @@ -48,7 +48,7 @@ namespace Lidgren.Network int bitsLeft = msg.LengthBits; for (int i = 0; i < numChunks; i++) { - NetOutgoingMessage chunk = CreateMessage(mtu); + NetOutgoingMessage chunk = CreateMessage(0); chunk.m_bitLength = (bitsLeft > bitsPerChunk ? bitsPerChunk : bitsLeft); chunk.m_data = msg.m_data; diff --git a/Lidgren.Network/NetPeer.MessagePools.cs b/Lidgren.Network/NetPeer.MessagePools.cs index 052b5fd..0a650f6 100644 --- a/Lidgren.Network/NetPeer.MessagePools.cs +++ b/Lidgren.Network/NetPeer.MessagePools.cs @@ -84,10 +84,8 @@ namespace Lidgren.Network /// public NetOutgoingMessage CreateMessage(string content) { - byte[] bytes = Encoding.UTF8.GetBytes(content); - NetOutgoingMessage om = CreateMessage(2 + bytes.Length); - om.WriteVariableUInt32((uint)bytes.Length); - om.Write(bytes); + var om = CreateMessage(2 + content.Length); // fair guess + om.Write(content); return om; } @@ -101,8 +99,8 @@ namespace Lidgren.Network if (m_outgoingMessagesPool == null || !m_outgoingMessagesPool.TryDequeue(out retval)) retval = new NetOutgoingMessage(); - byte[] storage = GetStorage(initialCapacity); - retval.m_data = storage; + if (initialCapacity > 0) + retval.m_data = GetStorage(initialCapacity); return retval; }