From 025172592f9ca9a96d865b95289e43cb1a3b8dd3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jonas=20Sch=C3=A4fer?= Date: Tue, 9 Mar 2021 22:20:37 +0100 Subject: [PATCH] Improve error handling in Prosody version retrieval --- snikket_web/prosodyclient.py | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/snikket_web/prosodyclient.py b/snikket_web/prosodyclient.py index bd2ed26..df9f201 100644 --- a/snikket_web/prosodyclient.py +++ b/snikket_web/prosodyclient.py @@ -514,9 +514,16 @@ class ProsodyClient: } async with session.post(self._rest_endpoint, data=req) as resp: + if resp.status != 200: + return "unknwn" try: return (await resp.json())["version"]["version"] - except: + except Exception as exc: + self.logger.debug( + "failed to parse prosody version from response" + " (%s: %s)", + type(exc), exc, + ) return "unknown" @autosession