From 33d28e5890f351438fe2f8aea07400f253195a39 Mon Sep 17 00:00:00 2001
From: Matthew Wild <mwild1@gmail.com>
Date: Tue, 16 Apr 2024 15:07:43 +0100
Subject: [PATCH] Show active user counts in instance metrics

---
 snikket_web/admin.py                    |  5 +++++
 snikket_web/templates/admin_system.html | 13 ++++++++++---
 2 files changed, 15 insertions(+), 3 deletions(-)

diff --git a/snikket_web/admin.py b/snikket_web/admin.py
index a32b405..083cdb1 100644
--- a/snikket_web/admin.py
+++ b/snikket_web/admin.py
@@ -812,6 +812,11 @@ async def system() -> typing.Union[str, werkzeug.Response]:
         except KeyError:
             pass
 
+        try:
+            metrics["users"] = prosody_metrics["users"]
+        except KeyError:
+            pass
+
         for k in list(metrics.keys()):
             if metrics[k] is None:
                 # so that defaulting in jinja works
diff --git a/snikket_web/templates/admin_system.html b/snikket_web/templates/admin_system.html
index fe547de..f929714 100644
--- a/snikket_web/templates/admin_system.html
+++ b/snikket_web/templates/admin_system.html
@@ -76,13 +76,20 @@
 			<em>{% trans %}unknown{% endtrans %}</em>
 			{%- endif -%}
 		</dd>
-		<dt>{% trans %}Connected devices{% endtrans %}</dt>
+		<dt>{% trans %}Active users{% endtrans %}</dt>
 		<dd>
+			<ul>
 			{%- if metrics.prosody_devices | default(None) is not none -%}
-			{{ metrics.prosody_devices }}
+			<li>{% trans %}Connected now:{% endtrans %} {{ metrics.prosody_devices }}</li>
 			{%- else -%}
-			<em>{% trans %}unknown{% endtrans %}</em>
+			<li><em>{% trans %}unknown{% endtrans %}</em></li>
 			{%- endif -%}
+			{%- if metrics.users | default(None) is not none -%}
+			<li>{% trans %}Past 24 hours:{% endtrans %} {{ metrics.users.active_1d }}</li>
+			<li>{% trans %}Past 7 days:{% endtrans %} {{ metrics.users.active_7d }}</li>
+			<li>{% trans %}Past 30 days:{% endtrans %} {{ metrics.users.active_30d }}</li>
+			{%- endif -%}
+			</ul>
 		</dd>
 	</dl>
 </div>