From 96f4b0d4f8a66ba6654b5a593eef09485313b270 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jonas=20Sch=C3=A4fer?= <j.wielicki@sotecware.net>
Date: Wed, 3 Feb 2021 18:47:03 +0100
Subject: [PATCH] Make version info only available on admin or debug sessions

---
 snikket_web/main.py              | 7 +++++--
 snikket_web/templates/about.html | 2 +-
 2 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/snikket_web/main.py b/snikket_web/main.py
index 4968bfd..00d8f38 100644
--- a/snikket_web/main.py
+++ b/snikket_web/main.py
@@ -79,8 +79,11 @@ async def login() -> typing.Union[str, quart.Response]:
 
 @bp.route("/meta/about.html")
 async def about() -> str:
+    version = None
     extra_versions = {}
-    if current_app.debug:
+
+    if current_app.debug or client.is_admin_session:
+        version = _version.version
         extra_versions["Quart"] = quart.__version__
         extra_versions["aiohttp"] = aiohttp.__version__
         extra_versions["babel"] = babel.__version__
@@ -89,7 +92,7 @@ async def about() -> str:
 
     return await render_template(
         "about.html",
-        version=_version.version,
+        version=version,
         extra_versions=extra_versions,
     )
 
diff --git a/snikket_web/templates/about.html b/snikket_web/templates/about.html
index cc5323f..0dfa3bf 100644
--- a/snikket_web/templates/about.html
+++ b/snikket_web/templates/about.html
@@ -17,7 +17,7 @@
 		<h3>{% trans %}Software Versions{% endtrans %}</h3>
 		<pre>Snikket Server
 Domain: {{ config["SNIKKET_DOMAIN"] }}
-Snikket Web Portal ({{ version }})
+Snikket Web Portal{% if version %} ({{ version }}){% endif %}
 {%- if extra_versions -%}
 {% for name, version in extra_versions.items() %}
 {{ name }} ({{ version }}){% endfor %}